fix: JSON checkpoint discovery ignores branch subdirectories#5501
Merged
Conversation
Branch-aware checkpoint storage writes under subdirectories (e.g. main/, fork/exp1/) but _list_json and _info_json_latest used flat globs that missed them.
iris-clawd
approved these changes
Apr 16, 2026
Contributor
iris-clawd
left a comment
iris-clawd
left a comment
There was a problem hiding this comment.
Clean fix — recursive glob for branch subdirectory checkpoint discovery, backward compatible with flat layout. 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
**/*.json) in_list_json()and_info_json_latest()so JSON checkpoints stored under branch subdirectories (e.g.main/,fork/exp1/) are discovered correctlyCloses #5491
Test plan
_list_json()discovers checkpoints in branch subdirectories_info_json_latest()returns the most recent checkpoint across all branchesNote
Low Risk
Small, localized change to filesystem globbing in the CLI; main risk is slight performance impact or unintended inclusion of extra
.jsonfiles under the checkpoint directory.Overview
Checkpoint CLI JSON discovery now searches recursively (via
**/*.json) when listing checkpoints and when computing the latest checkpoint, so checkpoints stored under branch/subdirectories are picked up alongside the legacy flat layout.Reviewed by Cursor Bugbot for commit 0de4ef9. Bugbot is set up for automated code reviews on this repo. Configure here.