fix(instructor): forward base_url and api_key to instructor.from_provider#5658
Merged
greysonlalonde merged 1 commit intomainfrom Apr 29, 2026
Merged
Conversation
iris-clawd
approved these changes
Apr 29, 2026
Contributor
iris-clawd
left a comment
There was a problem hiding this comment.
LGTM — forwards base_url/api_key to instructor.from_provider when set, clean and backward-compatible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5204
Note
Medium Risk
Touches LLM client instantiation and credential propagation (
api_key/base_url), which can affect runtime connectivity and authentication across providers. Change is small and guarded (only passes non-Nonevalues), with explicit unit coverage.Overview
InternalInstructor._create_instructor_clientnow propagatesbase_urlandapi_key(when set on a non-string LLM) intoinstructor.from_provider, enabling custom endpoints/credentials to be honored.Tests were updated to include
base_url/api_keyon the unsupported-provider mock and to add assertions that these fields are forwarded when provided and omitted whenNone.Reviewed by Cursor Bugbot for commit 7a83f7a. Bugbot is set up for automated code reviews on this repo. Configure here.