Skip to content

Display planning without search #97#106

Merged
mRoca merged 2 commits intomasterfrom
display-planning-without-search-#97
Mar 24, 2020
Merged

Display planning without search #97#106
mRoca merged 2 commits intomasterfrom
display-planning-without-search-#97

Conversation

@theyough
Copy link
Contributor

fix #97

@theyough theyough requested review from flobb and mtarld March 24, 2020 10:03
Copy link
Contributor

@mtarld mtarld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@mRoca mRoca force-pushed the display-planning-without-search-#97 branch from 9a85e72 to 673ea37 Compare March 24, 2020 16:26
->add('volunteerHideVulnerable', CheckboxType::class, [
'label' => 'Cacher les personnes signalées comme vulnérables',
->add('displayVulnerables', CheckboxType::class, [
'label' => 'Afficher aussi les personnes signalées comme vulnérables',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mRoca "aussi" ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oui, elles sont cachées par défaut. Cocher la case les ajoute à la liste

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

c'est le wording qui me gene un peu, je suis pas sur qu'il y est besoin d'ajouter "aussi"

@mRoca mRoca force-pushed the display-planning-without-search-#97 branch from 673ea37 to b1fdaa6 Compare March 24, 2020 16:34
@mRoca mRoca force-pushed the display-planning-without-search-#97 branch from b1fdaa6 to f66165e Compare March 24, 2020 16:35
Copy link
Contributor Author

@theyough theyough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mRoca mRoca merged commit 80cbf46 into master Mar 24, 2020
@mRoca mRoca deleted the display-planning-without-search-#97 branch March 24, 2020 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Display the planning without search

3 participants