css-refactor: replace SCSS font syntax with CSS in _form.scss#5317
Merged
veganstraightedge merged 1 commit intoApr 30, 2026
Merged
Conversation
* app/assets/stylesheets/2017/components/_forms.scss: renamed _form.scss to _form.css. Also replace the SCSS font syntax with CSS syntax.
Bargraph6
requested review from
astronaut-wannabe,
bookis,
eliduke,
evanphx,
guitsaru,
just1602 and
veganstraightedge
as code owners
Contributor
Author
|
@just1602 here's a small one ready for review |
veganstraightedge
approved these changes
Apr 30, 2026
This was referenced May 1, 2026
Bargraph6
added a commit
to Bargraph6/website
that referenced
this pull request
May 1, 2026
* `app/assets/stylesheets/2017/components/_forms.scss`: renamed `_forms.scss` to `_forms.css`. No further changes were needed. In [PR crimethinc#5317][0] I forgot to do the actual rename. --- related to: crimethinc#5317 related to: crimethinc#5212 [0]:crimethinc#5317
just1602
pushed a commit
that referenced
this pull request
May 1, 2026
# What are the relevant GitHub issues? related to: #5317 related to: #5212 # What does this pull request do? * `app/assets/stylesheets/2017/components/_forms.scss`: renamed `_forms.scss` to `_forms.css`. No further changes were needed. # Is there any background context you want to provide for reviewers? In PR #5317 I forgot to do the actual rename. # Acceptance Criteria ## These should be checked by the reviewers - [ ] This pull request does not cause the database export script to become out of sync with the db schema
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are the relevant GitHub issues?
resolves #5212
What does this pull request do?
app/assets/stylesheets/2017/components/_forms.scss: renamed_form.scssto_form.css. Also replace the SCSS font syntax with CSS syntax.Acceptance Criteria
These should be checked by the reviewers