Skip to content

To Change Everything in 한국어 and english#582

Merged
veganstraightedge merged 2 commits intomasterfrom
한국어-and-english
Jan 29, 2018

Hidden character warning

The head ref may contain hidden characters: "\ud55c\uad6d\uc5b4-and-english"
Merged

To Change Everything in 한국어 and english#582
veganstraightedge merged 2 commits intomasterfrom
한국어-and-english

Conversation

@astronaut-wannabe
Copy link
Copy Markdown
Contributor

@astronaut-wannabe astronaut-wannabe commented Dec 18, 2017

This is a first pass of just quickly slotting in the Korean text.

I still have a lot to do (comparing the korean web to PDF to adjust CSS, line breaks, highlights, etc)

I also noticed translation difference between the pdf and my source files.

e.g.

To change anything, start everywhere.

  • Source files: 무엇이 든지 바꾸기 위해, 모든 곳에서 시작하자.
  • The pdf: 무엇 이든 바꾸려면 모든 곳 에서 시작하자

will need to figure out how to resolve those differences

update: going with the pdf for layout/language guidance


demo

https://crimethinc-staging-pr-582.herokuapp.com/tce/%ED%95%9C%EA%B5%AD%EC%96%B4

progress screenshot

korean desktop

desktop

@astronaut-wannabe astronaut-wannabe self-assigned this Dec 18, 2017
@CobyR CobyR temporarily deployed to crimethinc-staging-pr-582 December 18, 2017 19:24 Inactive
@veganstraightedge veganstraightedge temporarily deployed to crimethinc-staging-pr-582 December 18, 2017 19:36 Inactive
@veganstraightedge
Copy link
Copy Markdown
Contributor

Looking real good. 👍🏻

@veganstraightedge veganstraightedge temporarily deployed to crimethinc-staging-pr-582 December 19, 2017 18:45 Inactive
@veganstraightedge veganstraightedge temporarily deployed to crimethinc-staging-pr-582 December 19, 2017 20:05 Inactive
@veganstraightedge veganstraightedge temporarily deployed to crimethinc-staging-pr-582 December 20, 2017 03:08 Inactive
@veganstraightedge veganstraightedge temporarily deployed to crimethinc-staging-pr-582 December 21, 2017 03:44 Inactive
@veganstraightedge veganstraightedge temporarily deployed to crimethinc-staging-pr-582 December 22, 2017 21:02 Inactive
@veganstraightedge veganstraightedge temporarily deployed to crimethinc-staging-pr-582 December 26, 2017 15:45 Inactive
@astronaut-wannabe
Copy link
Copy Markdown
Contributor Author

@veganstraightedge @just1602 any opinions on what to do with the last panel? In english and espanol it links out to "The Secret is to Begin"

I can think of 3 options:

In languages where that article is not translated, I could...

  1. link to the english version?
  2. hide the last panel
  3. show last panel, but it will not be a link (requires getting the phrase "the secret is to begin" translated)

@just1602
Copy link
Copy Markdown
Collaborator

@astronaut-wannabe if we keep in mind that implementation of a translation / multilanguage system is in the roadmap we could only translate the "the secret is to begin" and link it to the good translation when it'll be done?

@veganstraightedge
Copy link
Copy Markdown
Contributor

  1. link to the english version?
  2. hide the last panel
  3. show last panel, but it will not be a link (requires getting the phrase "the secret is to begin" translated)

I like 1 the best. It at least gives the reader the option of reading it in English or Google translating it.

At the same time, I'll put out some feelers to get it translated into Korean.

@veganstraightedge
Copy link
Copy Markdown
Contributor

Is this a copy/paste error / typo or something else?

screen shot 2017-12-26 at 12 31 36 pm

@veganstraightedge
Copy link
Copy Markdown
Contributor

Do you need these words translated? If so, what words are they?
screen shot 2017-12-26 at 12 32 25 pm
screen shot 2017-12-26 at 12 32 32 pm

@veganstraightedge
Copy link
Copy Markdown
Contributor

These two panels would probably read better as either white text with a little bit of black shadow or black text with a little bit of white shadow. Wanna try each and see how they look?
screen shot 2017-12-26 at 12 31 50 pm
Uploading Screen Shot 2017-12-26 at 12.32.04 PM.png…

@veganstraightedge
Copy link
Copy Markdown
Contributor

@astronaut-wannabe First "the secret is to begin" translation. We should corroborate that with a couple few folks still. But it can work as a placeholder for now.

Translation by: @jessabean.

https://twitter.com/jessabean/status/945842524853276673

@astronaut-wannabe
Copy link
Copy Markdown
Contributor Author

astronaut-wannabe commented Dec 27, 2017

@veganstraightedge

Is this a copy/paste error / typo or something else?

no, that is the design in the pdf

Do you need these words translated? If so, what words are they?

The first one is introduction I think. That should be safe to pull from a dictionary.

The second one is "order in bulk" and is more like the "The Secret is to Begin" issue. should I just hide that link in languages that do not have a translated /get page? Or is it possible to make a bulk order of korean TCE prints?

These two panels would probably read better as either white text with a little bit of black shadow or black text with a little bit of white shadow. Wanna try each and see how they look?

👍

First "the secret is to begin" translation. We should corroborate that with a couple few folks still. But it can work as a placeholder for now.

I checked this translation with a Korean friend. They said this wording makes sense

@veganstraightedge veganstraightedge temporarily deployed to crimethinc-staging-pr-582 December 27, 2017 19:27 Inactive
@veganstraightedge
Copy link
Copy Markdown
Contributor

The second one is "order in bulk" and is more like the "The Secret is to Begin" issue. should I just hide that link in languages that do not have a translated /get page? Or is it possible to make a bulk order of korean TCE prints?

I'm pretty sure only en/es are available for bulk orders.

If there isn't a /:lang/get page for that :lang, let's link to /tce/get (EN version) for now.

@veganstraightedge veganstraightedge temporarily deployed to crimethinc-staging-pr-582 December 28, 2017 16:42 Inactive
@veganstraightedge veganstraightedge temporarily deployed to crimethinc-staging-pr-582 December 28, 2017 17:22 Inactive
@CobyR CobyR temporarily deployed to crimethinc-staging-pr-582 January 2, 2018 22:03 Inactive
@CobyR CobyR temporarily deployed to crimethinc-staging-pr-582 January 19, 2018 20:39 Inactive
@astronaut-wannabe astronaut-wannabe force-pushed the 한국어-and-english branch 2 times, most recently from 62bf481 to cd6c2de Compare January 29, 2018 05:15
@astronaut-wannabe
Copy link
Copy Markdown
Contributor Author

astronaut-wannabe commented Jan 29, 2018

@veganstraightedge this should be good to go.

some css bugs for the korean may come in as it is viewed on more devices, but it looked good on everything I had on me

can you do a feature branch PR deploy for heroku so I can real quick view it in staging (to test the video link mainly)

@astronaut-wannabe astronaut-wannabe changed the title [WIP] To Change Everything in 한국어 and english To Change Everything in 한국어 and english Jan 29, 2018
Copy link
Copy Markdown
Contributor

@veganstraightedge veganstraightedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fuck yeah!

@veganstraightedge veganstraightedge merged commit 493e3a6 into master Jan 29, 2018
@veganstraightedge veganstraightedge deleted the 한국어-and-english branch January 29, 2018 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants