To Change Everything in 한국어 and english#582
Hidden character warning
Conversation
07260f4 to
aada66f
Compare
|
Looking real good. 👍🏻 |
aada66f to
8c28041
Compare
c1bcdde to
1302f32
Compare
1302f32 to
69ad60d
Compare
69ad60d to
c2805bb
Compare
|
@veganstraightedge @just1602 any opinions on what to do with the last panel? In english and espanol it links out to "The Secret is to Begin" I can think of 3 options: In languages where that article is not translated, I could...
|
|
@astronaut-wannabe if we keep in mind that implementation of a translation / multilanguage system is in the roadmap we could only translate the "the secret is to begin" and link it to the good translation when it'll be done? |
I like 1 the best. It at least gives the reader the option of reading it in English or Google translating it. At the same time, I'll put out some feelers to get it translated into Korean. |
|
@astronaut-wannabe First "the secret is to begin" translation. We should corroborate that with a couple few folks still. But it can work as a placeholder for now. Translation by: @jessabean. |
no, that is the design in the pdf
The first one is introduction I think. That should be safe to pull from a dictionary. The second one is "order in bulk" and is more like the "The Secret is to Begin" issue. should I just hide that link in languages that do not have a translated
👍
I checked this translation with a Korean friend. They said this wording makes sense |
I'm pretty sure only en/es are available for bulk orders. If there isn't a /:lang/get page for that :lang, let's link to |
7fc7fce to
f868207
Compare
62bf481 to
cd6c2de
Compare
|
@veganstraightedge this should be good to go. some css bugs for the korean may come in as it is viewed on more devices, but it looked good on everything I had on me can you do a feature branch PR deploy for heroku so I can real quick view it in staging (to test the video link mainly) |
cd6c2de to
4e525dd
Compare




This is a first pass of just quickly slotting in the Korean text.
I still have a lot to do (comparing the korean web to PDF to adjust CSS, line breaks, highlights, etc)
I also noticed translation difference between the pdf and my source files.e.g.Source files:무엇이 든지 바꾸기 위해, 모든 곳에서 시작하자.The pdf:무엇 이든 바꾸려면 모든 곳 에서 시작하자will need to figure out how to resolve those differencesupdate: going with the pdf for layout/language guidance
demo
https://crimethinc-staging-pr-582.herokuapp.com/tce/%ED%95%9C%EA%B5%AD%EC%96%B4
progress screenshot
korean desktop