[TCE] Add a first draft of a Persian version #603
Merged
veganstraightedge merged 2 commits intomasterfrom Jan 4, 2018
Merged
Conversation
astronaut-wannabe
force-pushed
the
tce-farsi
branch
2 times, most recently
from
575a2ce to
aa3aa16
Compare
astronaut-wannabe
changed the title
Contributor
Author
|
@veganstraightedge I think this is basically a serviceable rough-cut for production. I will create a PR to track all of the polish that still needs to be done also, here are the Farsi-specific images: done.zip |
astronaut-wannabe
changed the title
astronaut-wannabe
force-pushed
the
tce-farsi
branch
from
aa3aa16 to
b5b8880
Compare
We wanted to get a first draft of a farsiii version live on the site ASAP due to some current events. There probably still needs to be some work on polishing the CSS and making the site fully RTL (for example, the menu bar still reads LTR)
| <li><a href="/tce/espanol">Español</a></li> | ||
| <li><a href="http://www.crimethinc.com/blog/2016/09/21/to-change-everything-in-11-more-languages/#espanol">Español<br /> (América Latina)</a></li> | ||
| <li><a href="http://www.crimethinc.com/blog/2016/09/21/to-change-everything-in-11-more-languages/#farsi">فارسی</a></li> | ||
| <li><a href="/tce/فارسی">فارسی</a></li> |
Contributor
Author
There was a problem hiding this comment.
this seems to render as valid html, I think it is correct and just looks like this due to the html being ltr and the text being rtl.... not sure though
Contributor
|
Images uploaded. |
Contributor
|
There's a few tweaks that we should do for readability of text on top of images and the size of a couple, but this is pretty dang good enough to merge and launch. I'll make a separate issue for the tweaks. |
23 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We wanted to get a first draft of a farsiii version
live on the site ASAP due to some current events.
There probably still needs to be some work on polishing
the CSS and making the site fully RTL (for example, the menu
bar still reads LTR)
demo: https://crimethinc-staging-pr-603.herokuapp.com/tce/فارسی