Fix test expectations for server-provided token scheme casing#108
Closed
Copilot wants to merge 2 commits intofeature/dynamic-refreshfrom
Closed
Fix test expectations for server-provided token scheme casing#108Copilot wants to merge 2 commits intofeature/dynamic-refreshfrom
Copilot wants to merge 2 commits intofeature/dynamic-refreshfrom
Conversation
Co-authored-by: iwillspeak <1004401+iwillspeak@users.noreply.github.com>
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] Fix per-request auth token refresh logic
Fix test expectations for server-provided token scheme casing
Feb 20, 2026
Collaborator
|
already implemented by me - changing the mocked data to have the standard casing for Bearer and fixign the assertion for DPoP instead of changing both assertions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #106 changed the implementation to preserve server-provided token scheme casing instead of normalizing it. The tests were asserting normalized values, causing failures.
Changes:
test_get_token_successto expect"bearer"(lowercase, as returned by mock server) instead of"Bearer"test_get_token_respects_token_typeto expect"DPoP"(mixed case, as returned by mock server) instead of"Dpop"The tests now correctly validate that the implementation preserves exact server casing for OAuth token schemes.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.