Skip to content

Fix test expectations for server-provided token scheme casing#108

Closed
Copilot wants to merge 2 commits intofeature/dynamic-refreshfrom
copilot/sub-pr-103-again
Closed

Fix test expectations for server-provided token scheme casing#108
Copilot wants to merge 2 commits intofeature/dynamic-refreshfrom
copilot/sub-pr-103-again

Conversation

Copy link
Contributor

Copilot AI commented Feb 20, 2026

PR #106 changed the implementation to preserve server-provided token scheme casing instead of normalizing it. The tests were asserting normalized values, causing failures.

Changes:

  • Updated test_get_token_success to expect "bearer" (lowercase, as returned by mock server) instead of "Bearer"
  • Updated test_get_token_respects_token_type to expect "DPoP" (mixed case, as returned by mock server) instead of "Dpop"

The tests now correctly validate that the implementation preserves exact server casing for OAuth token schemes.


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: iwillspeak <1004401+iwillspeak@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Feb 20, 2026

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • astral.sh
    • Triggering command: /usr/bin/curl curl -LsSf REDACTED (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] Fix per-request auth token refresh logic Fix test expectations for server-provided token scheme casing Feb 20, 2026
Copilot AI requested a review from iwillspeak February 20, 2026 10:51
@anna-singleton-resolver
Copy link
Collaborator

already implemented by me - changing the mocked data to have the standard casing for Bearer and fixign the assertion for DPoP instead of changing both assertions

@snus-kin snus-kin deleted the copilot/sub-pr-103-again branch February 23, 2026 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants