Skip to content

ci: new CLI Scaffolding Validation workflow#673

Merged
joaoopereira merged 2 commits into
developmentfrom
copilot/add-github-actions-validation-workflow
Apr 7, 2026
Merged

ci: new CLI Scaffolding Validation workflow#673
joaoopereira merged 2 commits into
developmentfrom
copilot/add-github-actions-validation-workflow

Conversation

Copilot AI commented Mar 12, 2026

Copy link
Copy Markdown
Contributor

NOTE: See comment below for final PR description.

The scaffolding validation workflow only built the Linux binary (missing win-x64/osx-x64), repeated build+pack steps per-platform inline, and gated on PRs targeting main only.

Changes

  • New .github/scripts/build-and-pack.sh — single script with a for loop over all platforms (win-x64, linux-x64, osx-x64); accepts a mode argument:

    • bundle → outputs to npm/dist/<platform>/ (no zip, for npm packaging)
    • prod (default) → outputs to dist/<platform>/ and creates cmf-cli.<platform>.zip with a directory existence check before zipping
  • npm-publish.yml — drops the montudor/action-zip step and replaces npm run build:prod + 3 separate zip steps with a single bash .github/scripts/build-and-pack.sh

  • pr-scaffolding-validation.yml:

    • Removes branches: - main — now triggers on all PRs
    • Replaces npm run build:bundle:linux with bash .github/scripts/build-and-pack.sh bundle, building all three platforms via the shared script
- name: Build and pack CLI
  run: bash .github/scripts/build-and-pack.sh bundle  # all platforms, npm/dist/

📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.

Copilot AI changed the title [WIP] Add GitHub Actions workflow for CLI validation feat: add PR scaffolding validation workflow against latest MES Mar 12, 2026
Copilot AI requested a review from joaoopereira March 12, 2026 23:16
@joaoopereira joaoopereira marked this pull request as ready for review March 12, 2026 23:39
@joaoopereira joaoopereira changed the base branch from development to main March 12, 2026 23:41
@joaoopereira joaoopereira changed the base branch from main to development March 12, 2026 23:41
@joaoopereira joaoopereira marked this pull request as draft March 13, 2026 08:58
Copilot AI changed the title feat: add PR scaffolding validation workflow against latest MES ci: simplify build-and-pack with a shared script and run scaffolding validation on all PRs Mar 13, 2026
@Rockdell Rockdell force-pushed the copilot/add-github-actions-validation-workflow branch from ab31fdf to e9a9952 Compare March 25, 2026 11:33
@Rockdell

Rockdell commented Apr 6, 2026

Copy link
Copy Markdown
Contributor

Introduces scaffolding validation workflow that builds CLI and performs basic scaffolding commands (new, build and pack) and gated on PRs targeting main only.

Changes:

  • New CLI scaffolding validation workflow that run on PRs targeting the main branch. Can also be manually triggered.
  • Removed certain nuget packages (should be managed by SD) from our scaffolding templates that are not being consistently published each MES release.
  • Gated npm-publish workflow with a successful CLI scaffolding validation. Updated npm-publish workflow's actions to newer versions.

Successful pipeline run: https://github.com/criticalmanufacturing/cli/actions/runs/24036048518/job/70095810206

@Rockdell Rockdell changed the title ci: simplify build-and-pack with a shared script and run scaffolding validation on all PRs ci: new CLI Scaffolding Validation workflow Apr 6, 2026
@Rockdell Rockdell force-pushed the copilot/add-github-actions-validation-workflow branch 2 times, most recently from e8c513b to a1d65f7 Compare April 6, 2026 15:04
@Rockdell Rockdell marked this pull request as ready for review April 6, 2026 15:04
@joaoopereira joaoopereira enabled auto-merge (rebase) April 7, 2026 09:42
@Rockdell Rockdell force-pushed the copilot/add-github-actions-validation-workflow branch from a1d65f7 to b937ab2 Compare April 7, 2026 10:00
@github-actions

github-actions Bot commented Apr 7, 2026

Copy link
Copy Markdown
Contributor

.NET Test Results

View full test report

@github-actions

github-actions Bot commented Apr 7, 2026

Copy link
Copy Markdown
Contributor

Code Coverage

Package Line Rate Branch Rate Health
cmf 40% 39%
core 68% 49%
Summary 50% (5042 / 9999) 44% (2576 / 5892)

@joaoopereira joaoopereira merged commit 4cf59ad into development Apr 7, 2026
3 checks passed
@joaoopereira joaoopereira deleted the copilot/add-github-actions-validation-workflow branch April 7, 2026 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants