Fix streaming to preserve whitespace chunks in chat UI template#636
Merged
crmne merged 1 commit intocrmne:mainfrom Feb 26, 2026
Merged
Fix streaming to preserve whitespace chunks in chat UI template#636crmne merged 1 commit intocrmne:mainfrom
crmne merged 1 commit intocrmne:mainfrom
Conversation
String#blank? drops whitespace-only chunks (newlines, spaces) during streaming. LLM output can include content where whitespace is significant for correct rendering (e.g. Markdown), so use String#empty? instead to only skip truly empty chunks.
19 tasks
Owner
|
Good catch! |
crmne
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
String#blank?drops whitespace-only chunks (newlines, spaces) during streaming. LLM output can include content where whitespace is significant for correct rendering (e.g. Markdown), so useString#empty?instead to only skip truly empty chunks.Replaces #537 (was opened from main by mistake).