VertexAI: service account key support without ADC regressions#646
Merged
VertexAI: service account key support without ADC regressions#646
Conversation
…ation logic - Added `vertexai_service_account_key` to the configuration requirements for Vertex AI. - Updated the authorization method to use service account credentials if the key is provided, otherwise defaults to application default credentials.
We initially named this configuration `_hash` but was later updated to `_key`
…ion-key Change service account hash to key for authorizer
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #646 +/- ##
==========================================
+ Coverage 81.32% 81.35% +0.02%
==========================================
Files 116 116
Lines 5387 5390 +3
Branches 1411 1413 +2
==========================================
+ Hits 4381 4385 +4
+ Misses 1006 1005 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This replaces #532 with the same feature intent (Vertex AI service account support) while keeping ADC as the default path and avoiding regressions.
What changed
vertexai_service_account_keyoptional (do not require it in provider configuration requirements).Google::Auth.get_application_defaultcall to pass scopes positionally (compat with currentgoogleauthbehavior).spec/support/rubyllm_configuration.rb:vertexai_project_id/vertexai_locationassignmentsWhy replacement
PR #532 is from a fork with maintainer edits disabled, so we cannot push fixes directly to that branch.
Related