Fix agent not propagating assume_model_exists from class config#680
Merged
crmne merged 2 commits intocrmne:mainfrom Mar 16, 2026
Merged
Conversation
Owner
|
Thanks for catching and fixing this. I added a small follow-up to cover the remaining reload paths where Really appreciate the original report and fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Fixes #679
Fix Agent.find not propagating assume_model_exists from class-level config.
This is most likely to be encountered when attempting to "continue" a previous chat with an Agent.
Agent.find loads a chat record from the database and then calls apply_configuration, which triggers to_llm. to_llm creates a new RubyLLM::Chat using the record's assume_model_exists attribute — but since this is a transient attr_accessor, it defaults to nil/false after an ActiveRecord load. This causes Models.resolve to raise ModelNotFoundError for models not in the registry, even when the agent class declares assume_model_exists: true.
with_rails_chat_record (used by create/create!) doesn't have this problem because it spreads **chat_kwargs into the record constructor, which includes assume_model_exists: true:
record = resolved_chat_model.public_send(method_name, **chat_kwargs, **chat_options)
The find path was missing the equivalent propagation. This fix adds it by setting assume_model_exists from chat_kwargs on the loaded record before apply_configuration runs.
Type of change
Scope check
Required for new features
PRs for new features or enhancements without a prior approved issue will be closed.
Quality check
overcommit --installand all hooks passbundle exec rake vcr:record[provider_name]bundle exec rspecmodels.json,aliases.json)AI-generated code
API changes