Skip to content

Remove Code Duplication#732

Merged
crmne merged 1 commit intocrmne:mainfrom
Aesthetikx:remove_save_to_database_method_duplication
Apr 15, 2026
Merged

Remove Code Duplication#732
crmne merged 1 commit intocrmne:mainfrom
Aesthetikx:remove_save_to_database_method_duplication

Conversation

@Aesthetikx
Copy link
Copy Markdown
Contributor

@Aesthetikx Aesthetikx commented Apr 15, 2026

What this does

cf61b71 introduced the save_to_database method, but did not replace the (identical) partial implementation in the existing refresh! method.

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation
  • Performance improvement
  • Code maintainability

Scope check

  • I read the Contributing Guide
  • This aligns with RubyLLM's focus on LLM communication
  • This isn't application-specific logic that belongs in user code
  • This benefits most users, not just my specific use case

Quality check

  • I ran overcommit --install and all hooks pass
  • I tested my changes thoroughly
    • For provider changes: Re-recorded VCR cassettes with bundle exec rake vcr:record[provider_name]
    • All tests pass: bundle exec rspec
  • I updated documentation if needed
  • I didn't modify auto-generated files manually (models.json, aliases.json)

AI-generated code

  • I used AI tools to help write this code
  • I have reviewed and understand all generated code (required if above is checked)

API changes

  • Breaking change
  • New public methods/classes
  • Changed method signatures
  • No API changes

cf61b71 introduced the save_to_database method, but did not replace the
(identical) partial implementation in the existing refresh! method.
@crmne crmne merged commit 6c6ccda into crmne:main Apr 15, 2026
21 checks passed
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.17%. Comparing base (5156940) to head (9dd1b04).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #732      +/-   ##
==========================================
+ Coverage   86.16%   86.17%   +0.01%     
==========================================
  Files         118      118              
  Lines        5334     5331       -3     
  Branches     1350     1350              
==========================================
- Hits         4596     4594       -2     
+ Misses        738      737       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Aesthetikx Aesthetikx deleted the remove_save_to_database_method_duplication branch April 15, 2026 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants