Skip to content

Support URL-like deep links#7

Merged
marcospassos merged 1 commit intomasterfrom
improve-deep-link
Mar 24, 2025
Merged

Support URL-like deep links#7
marcospassos merged 1 commit intomasterfrom
improve-deep-link

Conversation

@marcospassos
Copy link
Member

Summary

Currently, only croct: and croct:/ links are supported. This PR updates the logic to also support croct://, which is the format most softwares (e.g: Slack) and websites expect to recognize a clickable link.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@marcospassos marcospassos added the enhancement New feature or request label Mar 24, 2025
@github-actions
Copy link

👋 @marcospassos
Thanks for your contribution!
The approval and merge process is almost fully automated 🧙
Here's how it works:

  1. You open a new pull request
  2. Automated tests check the code
  3. Maintainers review the code
  4. Once approved, the PR is ready to merge.

👉 Omit the extended description
Please remove the commit body before merging the pull request.
Instead, include the pull request number in the title to provide the full context
about the change.

☝️ Lastly, the title for the commit will come from the pull request title. So please provide a descriptive title that summarizes the changes in 50 characters or less using the imperative mood.
Happy coding! 🎉

@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 24, 2025

Open in Stackblitz

npm i https://pkg.pr.new/croct@7

commit: 9815685

@marcospassos marcospassos merged commit 5e9ff99 into master Mar 24, 2025
9 checks passed
@marcospassos marcospassos deleted the improve-deep-link branch March 24, 2025 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant