Skip to content

Remove bin/cro from provides#69

Merged
jnthn merged 1 commit intocroservices:masterfrom
ugexe:patch-1
Jun 20, 2018
Merged

Remove bin/cro from provides#69
jnthn merged 1 commit intocroservices:masterfrom
ugexe:patch-1

Conversation

@ugexe
Copy link
Contributor

@ugexe ugexe commented May 15, 2018

No description provided.

@jnthn
Copy link
Member

jnthn commented May 22, 2018

Are things under bin/ installed by convention, and thus don't need a mention anywhere in the META6.json?

@ugexe
Copy link
Contributor Author

ugexe commented May 22, 2018

We just don't have any way to declare bin/ scripts yet, although we should so that we can search for bin/scripts without having them installed.

On installation zef just greps bin/ and adds them to a non-spec field that CURI understands when installing. So what happens now is bin/cro gets installed to two spots in CURI -- resources/ and sources/ -- but only one ever gets used: resources/ ( Note this is CURI's resources/ folder, not the one in a distribution ). The problem, other than the extra file installed which isn't really a problem, is that when searching it is assumed provides means a certain thing so that zef install foobar doesn't install something with "provides" : { "foobar" : "bin/foobar.pl6" }

This is basically just a carry-over from panda, and ideally we'd have a "scripts" : [] META6.json field or some such along with a round of ecosystem PRs to add this field and its values to various modules.

@jnthn
Copy link
Member

jnthn commented Jun 20, 2018

Thanks for the explanation; merging so that this is in the next release.

@jnthn jnthn merged commit 17945cb into croservices:master Jun 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants