Skip to content
This repository was archived by the owner on Nov 8, 2018. It is now read-only.

Test for url building#2

Merged
andyhd merged 2 commits intomasterfrom
urljoining-test
Nov 24, 2016
Merged

Test for url building#2
andyhd merged 2 commits intomasterfrom
urljoining-test

Conversation

@pgchamberlin
Copy link
Copy Markdown
Contributor

@pgchamberlin pgchamberlin commented Nov 24, 2016

No description provided.

@pgchamberlin
Copy link
Copy Markdown
Contributor Author

pgchamberlin commented Nov 24, 2016

This test fails when using urljoin() instead of format() to concat. So it's capturing the original issue:

screen shot 2016-11-24 at 16 26 46

@pgchamberlin
Copy link
Copy Markdown
Contributor Author

pgchamberlin commented Nov 24, 2016

@andyhd this tests the change. It depends on the AGS_BROKER_URL in conftest.py no changing as I've hard-coded it's value (and it's format is significant to the test). Not sure if I could have done something different with that?

@andyhd
Copy link
Copy Markdown
Contributor

andyhd commented Nov 24, 2016

:shipit:

@andyhd andyhd merged commit 5d73aed into master Nov 24, 2016
@andyhd andyhd deleted the urljoining-test branch December 8, 2016 17:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pgchamberlin @andyhd