Merged
Conversation
…ng, and allow remove identifiers
…y rename; etc. (WIP)
…ity like other grids with prevent to save default; working on syncing primary status between entity attributes and identifiers section
…ers and vice-versa
…iers section changes, other minor updates
…ifiers, keeping the empty identifier to retain name; validation of attribute count removed; playwright delete test case updated
…st - attributes optional in identifier save
…erty on an attribute and specify separate identifier.
…ry, retaining other properties - including primary
harmen-xb
requested changes
Nov 11, 2025
Contributor
harmen-xb
left a comment
harmen-xb
left a comment
There was a problem hiding this comment.
@remonaadite009 Thanks for the updates, I have some questions/remarks on the tests.
e2e-tests/src/tests/diagram/system/add-edit-delete-attributes.spec.ts
Outdated
Show resolved
Hide resolved
e2e-tests/src/tests/diagram/system/add-edit-delete-attributes.spec.ts
Outdated
Show resolved
Hide resolved
e2e-tests/src/tests/diagram/system/add-edit-delete-attributes.spec.ts
Outdated
Show resolved
Hide resolved
e2e-tests/src/tests/diagram/system/add-edit-delete-attributes.spec.ts
Outdated
Show resolved
Hide resolved
Contributor
Author
|
I’ve added the changes. Could you please review them? |
Remove unneeded attributes form Customer example entity Updated getting attributes to always return string array Updated PlayWright scenarios for diagram attributes/identifiers and identifiers via entity form
harmen-xb
temporarily deployed
to
github-pages
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.