feat: add crossmodel edition info to DataModel#266
Merged
Conversation
Unit Test Results 2 files 17 suites 21s ⏱️ Results for commit 25beb9e. ♻️ This comment has been updated with latest results. |
harmen-xb
requested changes
Feb 3, 2026
Contributor
harmen-xb
left a comment
harmen-xb
left a comment
There was a problem hiding this comment.
@hardiksinh Thanks for the implementation, I added some questions and remarks.
Refactored deprecated function call in OnBuildUpdate method Removed crossmodel version and edition exported constants
Centralized update in datamodel manager on workspace load/reload
Updated version util to only update on major version update Added stability checks and refactored logging in datamodel manager Moved datamodel version check to validations. Fixed issue in serializer to properly handle 0 numeric values
harmen-xb
force-pushed
the
feature/crossmodel-version-in-datamodel
branch
from
3a591c5 to
a43f781
Compare
Contributor
Author
|
@harmen-xb LGTM. The no info warning and version mismatch error are displayed correctly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.