Add coderabbit config and clean up configuration#2
Open
adamwg wants to merge 3 commits intocrossplane:mainfrom
Open
Add coderabbit config and clean up configuration#2adamwg wants to merge 3 commits intocrossplane:mainfrom
adamwg wants to merge 3 commits intocrossplane:mainfrom
Conversation
Copy Crossplane's coderabbit config as a starting point and remove irrelevant parts. Signed-off-by: Adam Wolfe Gordon <awg@upbound.io>
We don't actually need CODEOWNERS for now, since we don't yet have dedicated reviewers for different areas. Branch protection rules require an approval from anyone with write access, which is sufficient. Signed-off-by: Adam Wolfe Gordon <awg@upbound.io>
The protos in this repository are vendored from crossplane/crossplane. There's no harm in linting them, but we don't need to push them to the buf schema registry. Set `push: false` on the buf action and remove the unnecessary token parameter, avoiding the need for a `BUF_TOKEN` secret in this repo. Signed-off-by: Adam Wolfe Gordon <awg@upbound.io>
jbw976
approved these changes
May 6, 2026
| uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6 | ||
|
|
||
| - name: Lint and Push Protocol Buffers | ||
| - name: Lint Protocol Buffers |
Member
There was a problem hiding this comment.
i'd argue we don't need to do the protobuf linting - we also copy protobufs from c/c to https://github.com/crossplane/function-sdk-go and we don't lint them there either - so that has precedent 🤔
| error testing uses proper patterns (cmpopts.EquateErrors, sentinel | ||
| errors for complex cases). | ||
|
|
||
| - path: "**/design/**" |
Member
There was a problem hiding this comment.
i see some patterns that are in c/c but not applicable here - want to take a pass to trim this down to only what's applicable in this repo?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Three small changes to our repository configuration:
I have:
./nix.sh flake checkto ensure this PR is ready for review.- [ ] Added or updated unit tests.- [ ] Linked a PR or a docs tracking issue to document this change.- [ ] Addedbackport release-x.ylabels to auto-backport this PR.