feat(transform): Add hash string conversion#3498
Merged
turkenh merged 2 commits intocrossplane:masterfrom Jan 24, 2023
Merged
Conversation
63d5fe6 to
e9144d1
Compare
fb18a65 to
e8f9e0d
Compare
3abecc0 to
29eb1f1
Compare
turkenh
reviewed
Jan 21, 2023
Comment on lines
+280
to
+281
| func stringGenerateHash[THash any](input any, hashFunc func([]byte) THash) (THash, error) { | ||
| inputJSON, err := json.Marshal(input) |
Member
There was a problem hiding this comment.
Is this the first usage of generics in Crossplane 🤔
Contributor
Author
There was a problem hiding this comment.
Its a feature of the newer Go version. Is that a problem? Its only a very small function.
29eb1f1 to
b013a42
Compare
Signed-off-by: Maximilian Blatt <maximilian.blatt-extern@deutschebahn.com> (external expert on behalf of DB Netz AG)
Signed-off-by: Maximilian Blatt <maximilian.blatt-extern@deutschebahn.com> (external expert on behalf of DB Netz AG)
b013a42 to
a0dc38e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
This adds three new string conversion function to patch transforms,
ToSha1,ToSha256,ToSha512, that generate a hash from the JSON representation of the input value.I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
composition.yamlxrd.yamlxrc.yaml