Skip to content

Set distinct app.kubernetes.io/component labels for rbac-manager (issue #6965)#7086

Closed
benzaidfoued wants to merge 1 commit intocrossplane:mainfrom
benzaidfoued:bugfix
Closed

Set distinct app.kubernetes.io/component labels for rbac-manager (issue #6965)#7086
benzaidfoued wants to merge 1 commit intocrossplane:mainfrom
benzaidfoued:bugfix

Conversation

@benzaidfoued
Copy link

Description of your changes

Fixes #6965

I have:

Need help with this checklist? See the cheat sheet.

@benzaidfoued benzaidfoued requested a review from a team as a code owner February 2, 2026 00:45
@benzaidfoued benzaidfoued requested a review from adamwg February 2, 2026 00:45
@benzaidfoued benzaidfoued changed the title set distinct app.kubernetes.io/component labels for rbac-manager (https://github.com/crossplane/crossplane/issues/6965) Set distinct app.kubernetes.io/component labels for rbac-manager (issue #6965) Feb 2, 2026
@coderabbitai
Copy link

coderabbitai bot commented Feb 2, 2026

📝 Walkthrough

Walkthrough

Adds component-specific app.kubernetes.io/component labels to the Deployment and PodTemplate metadata in two Helm chart templates so the core controller and RBAC manager are labeled distinctly.

Changes

Cohort / File(s) Summary
Crossplane deployment templates
cluster/charts/crossplane/templates/deployment.yaml, cluster/charts/crossplane/templates/rbac-manager-deployment.yaml
Insert include "crossplane.componentLabel" with component-specific values ("cloud-infrastructure-controller", "rbac-manager") into both metadata.labels and template.metadata.labels sections to differentiate components.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Thank you — would you like a brief note for the chart changelog mentioning the label fix?

🚥 Pre-merge checks | ✅ 5 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Title check ⚠️ Warning The title describes the main change (setting distinct component labels for rbac-manager) and references the related issue, but exceeds the 72-character limit at 78 characters. Shorten the title to 72 characters or fewer while preserving the key information, such as: 'Set distinct component labels for rbac-manager (#6965)'
✅ Passed checks (5 passed)
Check name Status Explanation
Description check ✅ Passed The description clearly explains the problem being fixed, the solution approach, and references the related issue #6965, making it well-related to the changeset.
Linked Issues check ✅ Passed The PR successfully addresses issue #6965 by adding distinct app.kubernetes.io/component labels for both the Crossplane controller and RBAC manager Deployments as required.
Out of Scope Changes check ✅ Passed All changes are directly aligned with the objective of setting distinct component labels; the modifications to both deployment.yaml and rbac-manager-deployment.yaml templates are in scope.
Breaking Changes ✅ Passed The custom check for breaking changes only applies to files under apis/** or cmd/** directories. The modified files in this PR are located in cluster/charts/crossplane/templates/, which falls completely outside the scope of this check.
Feature Gate Requirement ✅ Passed PR modifies only Helm chart labels to fix component labeling; no experimental features, API changes, or experimental behavior introduced.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Signed-off-by: Foued Benzaid <benzaid.foued@gmail.com>
Copy link
Member

@negz negz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this be a breaking change if someone is dependent on these labels?

@benzaidfoued
Copy link
Author

benzaidfoued commented Feb 2, 2026

Could this be a breaking change if someone is dependent on these labels?

I believe that upgrades remain safe due to the scope of the change ( limited to metadata.labels and
spec.template.metadata.labels )

@benzaidfoued benzaidfoued requested a review from negz February 4, 2026 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Helm chart: Different components have the same app.kubernetes.io/component label

2 participants