Set distinct app.kubernetes.io/component labels for rbac-manager (issue #6965)#7086
Set distinct app.kubernetes.io/component labels for rbac-manager (issue #6965)#7086benzaidfoued wants to merge 1 commit intocrossplane:mainfrom
Conversation
📝 WalkthroughWalkthroughAdds component-specific Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Thank you — would you like a brief note for the chart changelog mentioning the label fix? 🚥 Pre-merge checks | ✅ 5 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Signed-off-by: Foued Benzaid <benzaid.foued@gmail.com>
negz
left a comment
There was a problem hiding this comment.
Could this be a breaking change if someone is dependent on these labels?
I believe that upgrades remain safe due to the scope of the change ( limited to metadata.labels and |
Description of your changes
Fixes #6965
I have:
./nix.sh flake checkto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR.Need help with this checklist? See the cheat sheet.