Use Terraform name instead of CRD field name while resolving references#56
Merged
ulucinar merged 1 commit intocrossplane:mainfrom Aug 5, 2022
Merged
Use Terraform name instead of CRD field name while resolving references#56ulucinar merged 1 commit intocrossplane:mainfrom
ulucinar merged 1 commit intocrossplane:mainfrom
Conversation
muvaf
reviewed
Aug 4, 2022
pkg/registry/reference/references.go
Outdated
Member
There was a problem hiding this comment.
So, we used to give fieldName but now field_name. How is this working without a change in other places that processes the output here? Am I missing something?
Collaborator
Author
There was a problem hiding this comment.
What Terraformed.GetObservation and Terraformed.GetParameters both return is a map keyed with Terraform argument & attribute names (although they are serialized from spec.forProvider and status.atProvider of the respective CRDs).
Member
There was a problem hiding this comment.
Got it, so it wasn't working before anyway I guess. Thanks for the explanation!
Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
muvaf
approved these changes
Aug 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #55
Depends on: #15
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
Manually tested using the
NetworkInterfaceSgAttachmentresource.