Add comment-marker for generated reference-type comment lines#87
Merged
ulucinar merged 2 commits intocrossplane:mainfrom Aug 29, 2022
Merged
Add comment-marker for generated reference-type comment lines#87ulucinar merged 2 commits intocrossplane:mainfrom
ulucinar merged 2 commits intocrossplane:mainfrom
Conversation
Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
muvaf
approved these changes
Aug 29, 2022
| refComment = fmt.Sprintf("// References to %s to populate %s.\n%s", | ||
| friendlyTypeDescription(f.Reference.Type), f.Name.LowerCamelComputed, commentOptional.Build()) | ||
| selComment = fmt.Sprintf("Selector for a list of %s to populate %s.\n%s", | ||
| selComment = fmt.Sprintf("// Selector for a list of %s to populate %s.\n%s", |
Member
There was a problem hiding this comment.
Thanks for catching this! I think you need to fix the tests as well.
Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Looks like we are currently generating reference-type comment lines without the comment marker, i.e.,
//.I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
Running the code-gen pipeline with provider-{aws,azure,gcp}.