Filter terraform keyword in documentation#93
Merged
sergenyalcin merged 3 commits intocrossplane:mainfrom Sep 12, 2022
sergenyalcin:remove-terraform-keyword
Merged
Filter terraform keyword in documentation#93sergenyalcin merged 3 commits intocrossplane:mainfrom sergenyalcin:remove-terraform-keyword
sergenyalcin merged 3 commits intocrossplane:mainfrom
sergenyalcin:remove-terraform-keyword
Conversation
Signed-off-by: Sergen Yalçın <yalcinsergen97@gmail.com>
ulucinar
reviewed
Sep 9, 2022
pkg/common.go
Outdated
| // sentence. | ||
| func FilterDescription(description, keyword string) string { | ||
| var result []string | ||
| sentences := strings.Split(description, DescriptionSeparator) |
Collaborator
There was a problem hiding this comment.
We assume the description string will contain . only at the end of a sentence. Can you validate this across current providers?
ulucinar
reviewed
Sep 9, 2022
Signed-off-by: Sergen Yalçın <yalcinsergen97@gmail.com>
ulucinar
approved these changes
Sep 12, 2022
Collaborator
ulucinar
left a comment
ulucinar
left a comment
There was a problem hiding this comment.
Thank you @sergenyalcin, lgtm.
…ion. Signed-off-by: Sergen Yalçın <yalcinsergen97@gmail.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #567
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
Tested validating the results of
make generateforprovider-aws.