explicitly compose wait command #36
Merged
+15
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergenyalcin
approved these changes
Apr 15, 2025
Member
sergenyalcin
left a comment
sergenyalcin
left a comment
There was a problem hiding this comment.
Thanks @nekr0z LGTM! (And sorry for the late review :))
Member
|
Closing and re-opening for CI trigger |
Member
|
@nekr0z, it seems that one remaining case in unit tests needs to be fixed. Could you please fix it? After that, I will merge the PR. |
Chainsaw has `kubectl` hardcoded, so delete fails if it is not in $PATH. Signed-off-by: Evgeny Kuznetsov <eugenschmidt@yandex-team.ru>
Contributor
Author
@sergenyalcin Sure, here you go. Looks like that particular case was introduced while this PR was pending, so a rebase was required, hence the force-push. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chainsaw has
kubectlhardcoded, so wait fails if it is not in $PATH.This explicitly composes the wait command, using
${KUBECTL}forcommand, consistent with other places.
Fixes #34