Replies: 5 comments 1 reply
|
To be honest, I kinda like having zero settings, very minimal. One good font, one good formatting style. I open a book, I read, I don't fiddle with settings, trying to optimize everything. |
|
I think this is a critical feature - I am already finding several things I want to customize (power button delay, white sleep screen, no space between paragraphs - see https://github.com/jonasdiemer/crosspoint-reader/tree/my-quick-customizations). We first need to agree on where to store the settings. I don't like the idea of putting them to the SD card - they should survive changing cards... This leaves us with:
@daveallie what do you think? |
|
I would use SPIFFS for settings storage. |
|
Closing this off for now, may reconsider moving the settings out of a file into SPIFFS / NVS in the future. |
Uh oh!
There was an error while loading. Please reload this page.
Would be great to setup a new home screen (which you'd drop into on first boot and back out into when leaving the reader screen). From this screen a new settings screen could be added.
For a basic implementation of this, a new
SettingsScreenclass will be needed, along with a serializable class to hold the settings. Settings should be loaded on boot and be adjustable from the SettingsScreen.A simple setting to get the ball rolling would be toggling short/long press power to wake/sleep.
We could use NVS for the settings object, however that'll likely conflict with the XTOS settings meaning that whichever one was booted last will likely overwrite critical parts of that partition. The other option is to use a flat file in the
.crosspointdirectory. The downside there is that SPI initialization needs to happen asap now to fetch things like the short/long press to power on.At this point, I'm leaning towards the flat file to avoid breaking people's XTOS setup, with the intent to potentially move to NVS in future.
All reactions