feat: dictionary support#1402
Conversation
…at can hold multiple dictionaries (stardict format, one folder per dictionary) and a stting to choose between 'none' and any dictionary in the dictonary folder on the sd card -- this is a BREAKING, INCOMPLETE change
… code is within the validation method to keep everything related to validation in one place
…hich is 'too heavy' for the x4 -- this allows them to be extracted on-device
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
d211cc9 to
e12b54d
Compare
…ide the development of the expat processing engine that is planned for later
… remove '.ifo' file as a requirement to use dictionary, allow line wrap for all metadata fields/lines in ifo file display, add 'no ifo found' alert if trying to view metadata for a dict w/o ifo file
…ontent to be put in stardict output
…allow easier updates/management over time
…he dictionary activity was active
Optimize Lookup Speeds Using Custom Supplementary oft.cspt Files
@antziko I think by doing that you rebased your repo onto the kmn-custom branch instead of the feat-dictionary branch, which is this PR, so you didn't run into any build failures. mcrosson's crosspoint fork has the kmn-custom branch as the main cloned branch by default. Your solution therefore isn't an actual solution at all. I have now tried doing exactly what you said and cloned specifically the feat-dictionary branch, and the same build failure has appeared again. @mcrosson this is still an issue, stemming from the switch to Noto Serif upstream causing a build failure on the feat-dictionary branch of your fork of crosspoint, which is what this PR is based on. |
|
There was a bad push. I tested the update on the wrong device (I have 2 here) and pushed. About the time I realized the mistake my computer crashed and I'm waiting on a new PSU so I can fix the build. It should be sorted soon but I'm kind of stuck until a new PSU arrives for my computer. |
You are right, the default repo is not feat-dictionary. |
|
@mcrosson I think I've found a new bug on the latest version of this PR on the X4, where the lookup history is no longer capable of being updated. I looked up a new word multiple times and it did not get added to the lookup history for a book. |
fix: Remove DEBUG item in Main Menu Settings for Enabling/Disabling Lookup Popup
feat: Add .cpst generation for syn.oft files
Summary
docs/dictionary.md(link)docs/dictionary-development.md(link).dictionariesordictionariesfolder on sd carddocs/dictionary.mdfor details)Additional Context
See the discussion linked above for more detail on progress, planned changes, etc
General
RAM / ROM Usage Differences
AI Usage
Did you use AI tools to help write this code? YES - Claude ; chosen as the original PR I started with used AI.