Skip to content

Add buton hints to keyboard screen#205

Merged
daveallie merged 4 commits intocrosspoint-reader:masterfrom
olearycrew:feature/update-keyboard-screen-hints
Jan 3, 2026
Merged

Add buton hints to keyboard screen#205
daveallie merged 4 commits intocrosspoint-reader:masterfrom
olearycrew:feature/update-keyboard-screen-hints

Conversation

@olearycrew
Copy link
Copy Markdown
Contributor

Summary

This adds the correctly styled button hints to the keyboard screen as well as the ability to add hints to the side buttons (and up/down hints to that screen)

Additional Context

N/A

Copy link
Copy Markdown
Member

@daveallie daveallie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a positioning tweak

Comment on lines +335 to +336
// Position for the button group - buttons share a border so they're adjacent
constexpr int topButtonY = 320; // Top button position
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a little too high, lets shift it down a little so it's more aligned with the buttons

Image

@olearycrew
Copy link
Copy Markdown
Contributor Author

Cool @daveallie - I fixed this up as well as the build error.

Also I work for an AI code company that just added Code Reviews and we have an OSS program that can offer reviews for free - would love to get this project on-boarded if you're interested: https://kilo.ai/oss

@daveallie
Copy link
Copy Markdown
Member

Thanks @olearycrew! How have you found it works for C++ projects in the past, and have you found it works better than copilot? Interested to onboard it and test it out, obviously I haven't been the quickest with reviews to date and an additional AI review wouldn't hurt.

If you need an provide some onboarding details, you can reach me personally at dave [at] daveallie.com

@daveallie daveallie merged commit 8e4484c into crosspoint-reader:master Jan 3, 2026
1 check passed
yingirene pushed a commit to yingirene/crosspoint-reader that referenced this pull request Jan 16, 2026
## Summary

This adds the correctly styled button hints to the keyboard screen as
well as the ability to add hints to the side buttons (and up/down hints
to that screen)

## Additional Context

N/A
Unintendedsideeffects pushed a commit to Unintendedsideeffects/crosspoint-reader that referenced this pull request Feb 17, 2026
## Summary

This adds the correctly styled button hints to the keyboard screen as
well as the ability to add hints to the side buttons (and up/down hints
to that screen)

## Additional Context

N/A
whale-n pushed a commit to whale-n/njwiv-xt that referenced this pull request Mar 17, 2026
## Summary

This adds the correctly styled button hints to the keyboard screen as
well as the ability to add hints to the side buttons (and up/down hints
to that screen)

## Additional Context

N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants