Add buton hints to keyboard screen#205
Merged
daveallie merged 4 commits intocrosspoint-reader:masterfrom Jan 3, 2026
Merged
Conversation
daveallie
requested changes
Jan 2, 2026
Member
daveallie
left a comment
There was a problem hiding this comment.
Looks good, just a positioning tweak
lib/GfxRenderer/GfxRenderer.cpp
Outdated
Comment on lines
+335
to
+336
| // Position for the button group - buttons share a border so they're adjacent | ||
| constexpr int topButtonY = 320; // Top button position |
Member
Contributor
Author
|
Cool @daveallie - I fixed this up as well as the build error. Also I work for an AI code company that just added Code Reviews and we have an OSS program that can offer reviews for free - would love to get this project on-boarded if you're interested: https://kilo.ai/oss |
Member
|
Thanks @olearycrew! How have you found it works for C++ projects in the past, and have you found it works better than copilot? Interested to onboard it and test it out, obviously I haven't been the quickest with reviews to date and an additional AI review wouldn't hurt. If you need an provide some onboarding details, you can reach me personally at |
daveallie
approved these changes
Jan 3, 2026
yingirene
pushed a commit
to yingirene/crosspoint-reader
that referenced
this pull request
Jan 16, 2026
## Summary This adds the correctly styled button hints to the keyboard screen as well as the ability to add hints to the side buttons (and up/down hints to that screen) ## Additional Context N/A
Unintendedsideeffects
pushed a commit
to Unintendedsideeffects/crosspoint-reader
that referenced
this pull request
Feb 17, 2026
## Summary This adds the correctly styled button hints to the keyboard screen as well as the ability to add hints to the side buttons (and up/down hints to that screen) ## Additional Context N/A
whale-n
pushed a commit
to whale-n/njwiv-xt
that referenced
this pull request
Mar 17, 2026
## Summary This adds the correctly styled button hints to the keyboard screen as well as the ability to add hints to the side buttons (and up/down hints to that screen) ## Additional Context N/A
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
This adds the correctly styled button hints to the keyboard screen as well as the ability to add hints to the side buttons (and up/down hints to that screen)
Additional Context
N/A