fix: OPDS browser OOM#403
Merged
daveallie merged 8 commits intocrosspoint-reader:masterfrom Jan 21, 2026
Merged
Conversation
Contributor
Author
|
@daveallie Can you please review PR? |
daveallie
requested changes
Jan 19, 2026
Member
daveallie
left a comment
daveallie
left a comment
There was a problem hiding this comment.
Looks good, happy with this, just a small ask to bring it inline with the other stream based parsers we have.
lib/OpdsParser/OpdsParser.h
Outdated
| * @return true if parsing succeeded, false on error | ||
| */ | ||
| bool parse(const char* xmlData, size_t length); | ||
| void push(const char* xmlData, size_t length); |
Member
There was a problem hiding this comment.
Instead of this push method, and a completely separate OpdsStream class, let's subclass OpdsParser off Print (like we do for ContentOpfParser) and then implement write directly in this class.
daveallie
reviewed
Jan 21, 2026
| * } | ||
| */ | ||
| class OpdsParser { | ||
| class OpdsParser final : public Print { |
Member
There was a problem hiding this comment.
Do you think it's worthwhile to go all the way and just subclass Stream? Including the stubs for available, peek, and read in here?
Contributor
Author
There was a problem hiding this comment.
I think there is a mistake in the HttpClient library, because the implementation of the writeToStream method requires the Printer class, not the Stream class. But I don't want to make patches.
In addition, all other parsers are subclasses of Printer, and that's right, because they're all designed to be write-only streams.
daveallie
approved these changes
Jan 21, 2026
jdk2pq
added a commit
to jdk2pq/crosspoint-reader
that referenced
this pull request
Jan 23, 2026
* master: chore: Cut release 0.15.0 fix: OPDS browser OOM (crosspoint-reader#403) docs: Add detailed webserver documentation (crosspoint-reader#446) feat: invalidate cache on web uploads and opds downloads and add Clear Cache action (crosspoint-reader#393) fix: hard reset via RTS pin after flashing firmware (crosspoint-reader#437) fix: Skip negative screen coordinates only after we read the bitmap row. (crosspoint-reader#431) Reclaim space if we don't show battery Percentage (crosspoint-reader#352) feat: Include superscripts and subscripts in fonts (crosspoint-reader#463) My Library: Tab bar w/ Recent Books + File Browser (crosspoint-reader#250) feat: adding categories to settings screen (crosspoint-reader#331)
yingirene
pushed a commit
to yingirene/crosspoint-reader
that referenced
this pull request
Jan 25, 2026
## Summary - Rewrite OpdsParser to stream parsing instead of full content - Fix OOM due to big http xml response Closes crosspoint-reader#385 --- ### AI Usage While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it helps set the right context for reviewers. Did you use AI tools to help write this code? _**NO**_
Unintendedsideeffects
pushed a commit
to Unintendedsideeffects/crosspoint-reader
that referenced
this pull request
Feb 17, 2026
## Summary - Rewrite OpdsParser to stream parsing instead of full content - Fix OOM due to big http xml response Closes crosspoint-reader#385 --- ### AI Usage While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it helps set the right context for reviewers. Did you use AI tools to help write this code? _**NO**_
whale-n
pushed a commit
to whale-n/njwiv-xt
that referenced
this pull request
Mar 17, 2026
## Summary - Rewrite OpdsParser to stream parsing instead of full content - Fix OOM due to big http xml response Closes crosspoint-reader#385 --- ### AI Usage While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it helps set the right context for reviewers. Did you use AI tools to help write this code? _**NO**_
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #385
AI Usage
While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it
helps set the right context for reviewers.
Did you use AI tools to help write this code? NO