feat: Implement fix for sunlight fading issue#603
feat: Implement fix for sunlight fading issue#603daveallie merged 8 commits intocrosspoint-reader:masterfrom
Conversation
… fork) Point SDK submodule to allgoewer/open-x4-epaper-community-sdk commit 9c86003 which adds turnOffScreen parameter to displayBuffer() and displayWindow(), required by crosspoint PR crosspoint-reader#603 (sunlight fading fix). Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
…to custom-v16 sandbox Merge PR crosspoint-reader#603 (sunlight fading fix) with settings serialization conflict resolved: fadingFix placed at position 25 after powerButtonHoldDuration (position 24), SETTINGS_COUNT incremented to 25. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
I still got no feedback from anyone regarding the effectiveness of this PR. I was able to do only limited testing due to weather conditions but it seemed to do the trick. |
|
as discussed in #561 (comment) seems to be working. |
68c4ad8 to
73c9a85
Compare
* master: feat: add shift lock to KeyboardEntryActivity (crosspoint-reader#513) feat: rename and move in file manager (crosspoint-reader#630) feat: Implement fix for sunlight fading issue (crosspoint-reader#603) chore: Add PR title check on sync (crosspoint-reader#698) feat: Go To Position for epubs (crosspoint-reader#666) feat: Calibre Web Automated (CWA) koreader sync server support (crosspoint-reader#594) chore: Add CI check job to consolidate status (crosspoint-reader#696) chore: CI Build Summary - firmware stats, firmware artifact (crosspoint-reader#601) feat: quick rotate option in epub reader menu (crosspoint-reader#685) feat(settings): add "Cover + Custom" sleep screen mode (crosspoint-reader#582) fix: Artifacts on Thumb on Home Screen (crosspoint-reader#662) feat: holding back button while booting, boots to home screen as a mean of escaping boot loop (crosspoint-reader#587) docs: Add small SCOPE.md and GOVERNANCE.md documents (crosspoint-reader#640) feat: front button remapper (crosspoint-reader#664) feat: UI themes, Lyra (crosspoint-reader#528) feat: Add CSS parsing and CSS support in EPUBs (crosspoint-reader#411) fix: move http upload state to heap (crosspoint-reader#657)
|
Nice fix, I got the black version anyway but would this theoretically save battery as well? |
|
In theory, yes. But I didn't measure. |
## Summary * **What is the goal of this PR?** The goal of this PR is to deliver a fix for or at least mitigate the impact of the issue described in crosspoint-reader#561 * **What changes are included?** This PR includes a new option "Sunlight Fading Fix" under "Settings -> Display". When set to ON, we will disable the displays analog supply voltage after every update and turn it back on before the next update. ## Additional Context * Until now, I was only able to do limited testing because of limited sunlight at my location, but the fix seems to be working. I'll also attach a pre-built binary based on 0.16.0 (current master) with the fix applied to the linked ticket, as building this fix is a bit annoying because the submodule open-x4-sdk also needs an update. * [PR in open-x4-sdk](open-x4-epaper/community-sdk#15) needs to be merged first, we also need to add another commit to this here PR, updating this dependency. * I decided to hide this behind a default-OFF option. While I'm not really concerned that this fix might potentially damage the display, someone more knowledgeable on E-Ink technology could maybe have a look at this. * There's a binary attached in the linked issue, if someone has the required sunlight to test this in-depth. --- ### AI Usage While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it helps set the right context for reviewers. Did you use AI tools to help write this code? _**NO**_ --------- Co-authored-by: Dave Allie <dave@daveallie.com>
|
doesn't actually seem to work for me :( but setting the refresh interval to every page-turn keeps the text readable enough |
|
@insunaa Would you mind providing a short clip? Are you sure there is no difference between enabled / disabled fix? |
Are you sure it's because of the sun? I perceive degradation of the screen, and I always have the two X4s (black and white) in my room without any exposure to the sun. Somebody has made a post in reddit comparing 0.16 vs 1.1.0 and the old version of the firmware showed more contrast in the black screen than in the newer FW. |
|
@pablohc some people on reddit speculated it was caused by infrared light heating the ink particles and changing their magnetism for a short bit @allgoewer I'll make a video as soon as there's sunlight in my area again. For me the fading isn't just the dark pixels turning light, it's also the light pixels splotchily turning dark and after-images of the last ~5-10 refreshes appearing. this happens much more strongly if I am actively flipping pages, but it also happens to the book cover when the device is in deep sleep (as in: put it to sleep while not affected by sunlight and then several minutes later exposing it to direct sunlight) it also doesn't seem to be affected by UV-A (365nm), I have a UV-A flashlight and neither shining it at the e-ink screen nor shining it between the buttons or into the USB-C port causes any noticeable changes to the display content (regardless of whether the fix is enabled or not) |
|
Yeah, that sounds like a completely different issue. |
## Summary * **What is the goal of this PR?** The goal of this PR is to deliver a fix for or at least mitigate the impact of the issue described in crosspoint-reader#561 * **What changes are included?** This PR includes a new option "Sunlight Fading Fix" under "Settings -> Display". When set to ON, we will disable the displays analog supply voltage after every update and turn it back on before the next update. ## Additional Context * Until now, I was only able to do limited testing because of limited sunlight at my location, but the fix seems to be working. I'll also attach a pre-built binary based on 0.16.0 (current master) with the fix applied to the linked ticket, as building this fix is a bit annoying because the submodule open-x4-sdk also needs an update. * [PR in open-x4-sdk](open-x4-epaper/community-sdk#15) needs to be merged first, we also need to add another commit to this here PR, updating this dependency. * I decided to hide this behind a default-OFF option. While I'm not really concerned that this fix might potentially damage the display, someone more knowledgeable on E-Ink technology could maybe have a look at this. * There's a binary attached in the linked issue, if someone has the required sunlight to test this in-depth. --- ### AI Usage While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it helps set the right context for reviewers. Did you use AI tools to help write this code? _**NO**_ --------- Co-authored-by: Dave Allie <dave@daveallie.com>
Summary
The goal of this PR is to deliver a fix for or at least mitigate the impact of the issue described in #561
This PR includes a new option "Sunlight Fading Fix" under "Settings -> Display".
When set to ON, we will disable the displays analog supply voltage after every update and turn it back on before the next update.
Additional Context
AI Usage
While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it
helps set the right context for reviewers.
Did you use AI tools to help write this code? NO