-
Notifications
You must be signed in to change notification settings - Fork 85
designate: Deploy producer on server nodes (SOC-9766) #2175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
dirkmueller
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Producer is not active/active. Either use a pacemaker resource Singleton or a dlm. Please consult https://docs.openstack.org/designate/latest/admin/ha.html for further details.
0449667 to
e40db2d
Compare
|
This will require two packages to be added to Cloud (or at least I can't find them there), which are python2-pymemcache and python2-future. |
Designate has another service 'producer', which is used to run long-running periodic tasks. Install the package and start the service on one of the server nodes, monitored by pacemaker.
e40db2d to
0a0c48c
Compare
| end | ||
| service_transaction_objects << "pacemaker_primitive[#{designate_producer_primitive}]" | ||
|
|
||
| designate_producer_loc = openstack_pacemaker_controller_only_location_for designate_producer_primitive |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Metrics/LineLength: Line is too long. [102/100] (https://github.com/SUSE/style-guides/blob/master/Ruby.md#metricslinelength)
| # Recipe:: api | ||
| # | ||
|
|
||
| package "openstack-designate-producer" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isn't that done by the designate_service resource already?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I see, this is to install the package so that the singleton service (which is done after the sync mark?) will always be able to start. a comment would be helpful (of a thing like "if ha_enabled", needs to be moved a few lines down then)
dirkmueller
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks okay to me. the only concern I have is that when a customer switches from non-HA to HA, we don't revert the systemctl enable that is done on the service , and then we have it potentially running twice. we maybe want to drop in a service disable into the ha codepath just to be sure.
nicolasbock
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Designate has another service 'producer', which is used to run
long-running periodic tasks. Install the package and start the service
on nodes with the server role.