Add Sahara barclamp

[Itxaka]

This is basically #365 fixed and improved upon.

[houndci-bot]

Files should end with a trailing newline

[vuntz]

Do we usually expose the use_syslog setting? I think it's hidden for all other barclamps.

[Itxaka]

Indeed, other barclamps do not expose this. But we still have the switch in the configuration to enable or disable it based on node[barclamp][:use_syslog], so why not expose it to the user and set it to a default value? And if we want it to be always false (because of supportconfig?) then whyset a switch instead of setting it to false on the template directly?

Knowing that we do not have a central logging system in place for crowbar, enabling this means that there is a cheap and easy way for customers to use syslog as forwarder to set up their own centralized log management.

[toabctl]

Ummm. Hound finding stuff now that was already in there since the start? was hound broken?

Maybe the Hound creators changed something. I would just ignore hound as long as I'm not able to run it locally with a reproducible result ( but I guess I'm the only one with that opinion).

[toabctl]

Ummm. Hound finding stuff now that was already in there since the start? was hound broken?

Maybe the Hound creators changed something. I would just ignore hound as long as I'm not able to run it locally with a reproducible result ( but I guess I'm the only one with that opinion).

[toabctl]

+1

[toabctl]

+1

[toabctl]

And while I'm already complaining - LGTM is also useless - you updated the PR and it still shows that there are 2 +1's. tsts (end of complain mode)

[toabctl]

And while I'm already complaining - LGTM is also useless - you updated the PR and it still shows that there are 2 +1's. tsts (end of complain mode)

[dguitarbite]

+1 from my side. Thanks for updating the PR.

[dguitarbite]

+1 from my side. Thanks for updating the PR.

[Itxaka]

goddammit hound

[Itxaka]

goddammit hound

[Itxaka]

waiting for #523

[Itxaka]

waiting for #523

[toabctl]

@Itxaka Error: Committing the crowbar 'default' proposal for 'sahara' failed (1)..:

[2016-09-08T18:13:30+00:00] WARN: Current  execute[a2enmod deflate]: /var/chef/cache/cookbooks/apache2/definitions/apache_module.rb:28:in `block in from_file'
================================================================================
Recipe Compile Error in /var/chef/cache/cookbooks/sahara/recipes/role_sahara_server.rb
================================================================================
NameError
---------
uninitialized constant Chef::Recipe::SaharaHelper
Cookbook Trace:
---------------
  /var/chef/cache/cookbooks/sahara/recipes/common.rb:18:in `from_file'
  /var/chef/cache/cookbooks/sahara/recipes/role_sahara_server.rb:18:in `from_file'
Relevant File Content:
----------------------
/var/chef/cache/cookbooks/sahara/recipes/common.rb:
 11:  # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 12:  # See the License for the specific language governing permissions and
 13:  # limitations under the License.
 14:  #
 15:  
 16:  package "openstack-sahara"
 17:  
 18>> network_settings = SaharaHelper.network_settings(node)
 19:  db_settings = fetch_database_settings
 20:  
 21:  include_recipe "database::client"
 22:  include_recipe "#{db_settings[:backend_name]}::client"
 23:  include_recipe "#{db_settings[:backend_name]}::python-client"
 24:  
 25:  # get Database data
 26:  db_password = node[:sahara][:db][:password]
 27:  sql_connection = "#{db_settings[:url_scheme]}://#{node[:sahara][:db][:user]}:"\
[2016-09-08T18:13:30+00:00] ERROR: Running exception handlers

[toabctl]

@Itxaka Error: Committing the crowbar 'default' proposal for 'sahara' failed (1)..:

[2016-09-08T18:13:30+00:00] WARN: Current  execute[a2enmod deflate]: /var/chef/cache/cookbooks/apache2/definitions/apache_module.rb:28:in `block in from_file'
================================================================================
Recipe Compile Error in /var/chef/cache/cookbooks/sahara/recipes/role_sahara_server.rb
================================================================================
NameError
---------
uninitialized constant Chef::Recipe::SaharaHelper
Cookbook Trace:
---------------
  /var/chef/cache/cookbooks/sahara/recipes/common.rb:18:in `from_file'
  /var/chef/cache/cookbooks/sahara/recipes/role_sahara_server.rb:18:in `from_file'
Relevant File Content:
----------------------
/var/chef/cache/cookbooks/sahara/recipes/common.rb:
 11:  # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 12:  # See the License for the specific language governing permissions and
 13:  # limitations under the License.
 14:  #
 15:  
 16:  package "openstack-sahara"
 17:  
 18>> network_settings = SaharaHelper.network_settings(node)
 19:  db_settings = fetch_database_settings
 20:  
 21:  include_recipe "database::client"
 22:  include_recipe "#{db_settings[:backend_name]}::client"
 23:  include_recipe "#{db_settings[:backend_name]}::python-client"
 24:  
 25:  # get Database data
 26:  db_password = node[:sahara][:db][:password]
 27:  sql_connection = "#{db_settings[:url_scheme]}://#{node[:sahara][:db][:user]}:"\
[2016-09-08T18:13:30+00:00] ERROR: Running exception handlers

[Itxaka]

Thanks @toabctl should be fixed. That was a very dumb mistake :D

[Itxaka]

Thanks @toabctl should be fixed. That was a very dumb mistake :D

[toabctl]

I retriggered gating with want_sahara=1...

[toabctl]

I retriggered gating with want_sahara=1...

[nicolasbock]

+1

[nicolasbock]

+1

[Itxaka]

Retriggered with want_sahara. Did a mistake and set the port to the host and the host to the port so the service wasnt coming up :D

[Itxaka]

Retriggered with want_sahara. Did a mistake and set the port to the host and the host to the port so the service wasnt coming up :D

[dguitarbite]

+1

[dguitarbite]

+1

[Itxaka]

@vuntz @aspiers Any last comments before I merge? I think I covered all your requests :)

[Itxaka]

@vuntz @aspiers Any last comments before I merge? I think I covered all your requests :)