Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd Sahara barclamp #480
Conversation
houndci-bot
reviewed
Aug 3, 2016
| = t(".logging_header") | ||
| = boolean_field :verbose | ||
| = boolean_field :debug | ||
| = boolean_field :use_syslog |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
vuntz
Sep 7, 2016
Member
Do we usually expose the use_syslog setting? I think it's hidden for all other barclamps.
vuntz
Sep 7, 2016
Member
Do we usually expose the use_syslog setting? I think it's hidden for all other barclamps.
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Itxaka
Sep 7, 2016
Contributor
Indeed, other barclamps do not expose this. But we still have the switch in the configuration to enable or disable it based on node[barclamp][:use_syslog], so why not expose it to the user and set it to a default value? And if we want it to be always false (because of supportconfig?) then whyset a switch instead of setting it to false on the template directly?
Knowing that we do not have a central logging system in place for crowbar, enabling this means that there is a cheap and easy way for customers to use syslog as forwarder to set up their own centralized log management.
Itxaka
Sep 7, 2016
Contributor
Indeed, other barclamps do not expose this. But we still have the switch in the configuration to enable or disable it based on node[barclamp][:use_syslog], so why not expose it to the user and set it to a default value? And if we want it to be always false (because of supportconfig?) then whyset a switch instead of setting it to false on the template directly?
Knowing that we do not have a central logging system in place for crowbar, enabling this means that there is a cheap and easy way for customers to use syslog as forwarder to set up their own centralized log management.
Itxaka
added
wip
do not merge yet
labels
Aug 4, 2016
Itxaka
removed
the
wip
label
Aug 5, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
toabctl
Sep 7, 2016
Contributor
Ummm. Hound finding stuff now that was already in there since the start? was hound broken?
Maybe the Hound creators changed something. I would just ignore hound as long as I'm not able to run it locally with a reproducible result ( but I guess I'm the only one with that opinion).
Maybe the Hound creators changed something. I would just ignore hound as long as I'm not able to run it locally with a reproducible result ( but I guess I'm the only one with that opinion). |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
+1 |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
toabctl
Sep 7, 2016
Contributor
And while I'm already complaining - LGTM is also useless - you updated the PR and it still shows that there are 2 +1's. tsts (end of complain mode)
|
And while I'm already complaining - LGTM is also useless - you updated the PR and it still shows that there are 2 +1's. tsts (end of complain mode) |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
+1 from my side. Thanks for updating the PR. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
goddammit hound |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
waiting for #523 |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
toabctl
Sep 9, 2016
Contributor
@Itxaka Error: Committing the crowbar 'default' proposal for 'sahara' failed (1)..:
[2016-09-08T18:13:30+00:00] WARN: Current execute[a2enmod deflate]: /var/chef/cache/cookbooks/apache2/definitions/apache_module.rb:28:in `block in from_file'
================================================================================
Recipe Compile Error in /var/chef/cache/cookbooks/sahara/recipes/role_sahara_server.rb
================================================================================
NameError
---------
uninitialized constant Chef::Recipe::SaharaHelper
Cookbook Trace:
---------------
/var/chef/cache/cookbooks/sahara/recipes/common.rb:18:in `from_file'
/var/chef/cache/cookbooks/sahara/recipes/role_sahara_server.rb:18:in `from_file'
Relevant File Content:
----------------------
/var/chef/cache/cookbooks/sahara/recipes/common.rb:
11: # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12: # See the License for the specific language governing permissions and
13: # limitations under the License.
14: #
15:
16: package "openstack-sahara"
17:
18>> network_settings = SaharaHelper.network_settings(node)
19: db_settings = fetch_database_settings
20:
21: include_recipe "database::client"
22: include_recipe "#{db_settings[:backend_name]}::client"
23: include_recipe "#{db_settings[:backend_name]}::python-client"
24:
25: # get Database data
26: db_password = node[:sahara][:db][:password]
27: sql_connection = "#{db_settings[:url_scheme]}://#{node[:sahara][:db][:user]}:"\
[2016-09-08T18:13:30+00:00] ERROR: Running exception handlers
|
@Itxaka
|
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Thanks @toabctl should be fixed. That was a very dumb mistake :D |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
I retriggered gating with |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
+1 |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Itxaka
Sep 13, 2016
Contributor
Retriggered with want_sahara. Did a mistake and set the port to the host and the host to the port so the service wasnt coming up :D
|
Retriggered with want_sahara. Did a mistake and set the port to the host and the host to the port so the service wasnt coming up :D |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
+1 |
Itxaka commentedAug 2, 2016
•
edited
This is basically #365 fixed and improved upon.