Is there an existing issue for this?
Current Behavior
Anonymous community gift subs do not get grouped together into one event like non-anonymous community gift subs. Can be observed in this clip: https://clips.twitch.tv/LitigiousCrazyMelonPartyTime-8VdOBiDaX883XdoB
This vaguely appears to be a regression of #1798. Looking through the diff of 5.54.3 to 5.55.0, it seems like the anonymous fallback name is being set to "An Anonymous Gifter" for the community gift header and "Anonymous" for the individual subs, causing the community gift sub cache keys to not match:
|
subInfo.gifterDisplayName ?? "An Anonymous Gifter", |
|
subInfo.plan, |
|
subInfo.count |
|
); |
|
}); |
|
|
|
streamerChatClient.onSubGift((_channel, _user, subInfo) => { |
|
twitchEventsHandler.giftSub.triggerSubGift( |
|
subInfo.gifterDisplayName ?? "Anonymous", |
|
communitySubCache.set<CommunityGiftSubCache>(`${gifterDisplayName}:${subPlan}`, {subCount, giftReceivers: []}); |
Expected Behavior
Anonymous community gift subs get grouped together
Steps To Reproduce
No response
Version
5.55.0
What operating system are you using Firebot on?
Windows 10
Relevant log output
No response
Contact Details (Optional)
oh_mg#1234
Is there an existing issue for this?
Current Behavior
Anonymous community gift subs do not get grouped together into one event like non-anonymous community gift subs. Can be observed in this clip: https://clips.twitch.tv/LitigiousCrazyMelonPartyTime-8VdOBiDaX883XdoB
This vaguely appears to be a regression of #1798. Looking through the diff of 5.54.3 to 5.55.0, it seems like the anonymous fallback name is being set to "An Anonymous Gifter" for the community gift header and "Anonymous" for the individual subs, causing the community gift sub cache keys to not match:
Firebot/src/backend/chat/chat-listeners/twitch-chat-listeners.js
Lines 126 to 134 in c730740
Firebot/src/backend/events/twitch-events/gift-sub.ts
Line 25 in c730740
Expected Behavior
Anonymous community gift subs get grouped together
Steps To Reproduce
No response
Version
5.55.0
What operating system are you using Firebot on?
Windows 10
Relevant log output
No response
Contact Details (Optional)
oh_mg#1234