feat: implement waiting for video finish#2001
Merged
ebiggz merged 6 commits intocrowbartools:v5from Jan 12, 2023
Merged
Conversation
ebiggz
approved these changes
Jan 12, 2023
Member
ebiggz
left a comment
ebiggz
left a comment
There was a problem hiding this comment.
This looks great! Awesome work!
ebiggz
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
This Pull Request implements waiting for a Local video to complete.
Applicable Issues
#1958
#1859
#1783 (Partly, would rely on waiting for video)
Testing
I've tested to ensure that the effect will always continue execution after the video finishes playing. In order to ensure this, loop is disabled when wait for video to finish is enabled.
Screenshots
Play Video Effect Duration, Wait for video to finish is not ticked.
Play Video Effect Duration, Wait for video to finish is ticked and Loop is automatically unticked.