fix: long videos resourceToken expires before video finish#2059
Merged
ebiggz merged 4 commits intocrowbartools:v5from Feb 5, 2023
Merged
fix: long videos resourceToken expires before video finish#2059ebiggz merged 4 commits intocrowbartools:v5from
ebiggz merged 4 commits intocrowbartools:v5from
Conversation
ebiggz
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
Resource token length for videos is now dynamically fetched from the overlay instead of relying on being set as video duration by the user.
Applicable Issues
#2058
Testing
I've tested to make sure that there's no noticeable delay on video start, and the video would complete fully.
Screenshots
N/A