Merged
Conversation
ebiggz
approved these changes
Feb 25, 2023
Member
|
Great stuff, thanks for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
This Pull Request adds an effect that takes a screenshot of an OBS Source or Scene, saving it to a file.
It exposes OBS Websocket's quality and size scaling settings as optional options.
Internally, it uses the
GetSourceScreenshotcall rather thanSaveSourceScreenshotto allow saving the image on the firebot machine in a multi-PC setup.The OBS Source dropdown is searchable both by source/scene name, as well as type (currently the id of the type rather than the human friendly name, as OBS Websocket doesn't expose that.)
Applicable Issues
N/A
Testing
I have verified that the image file gets written properly when OBS is connected and sends back the image as a base64 URI. I have also verified that
nullis returned when OBS is not connected or when there is an error, and there is no attempt to save the file.Screenshots