fix(effects): File Writer Newline Escapes (#3025)#3029
Merged
ebiggz merged 2 commits intocrowbartools:v5from Mar 10, 2025
Merged
fix(effects): File Writer Newline Escapes (#3025)#3029ebiggz merged 2 commits intocrowbartools:v5from
ebiggz merged 2 commits intocrowbartools:v5from
Conversation
- Replace \n with a newline, but replace \\n with a backslash n. - Temporarily uses the `sub`, ASCII 0x1A, html &crowbartools#26; character for temporary staging to skip over the newline regex. - crowbartools#3025
- I do have to question why anyone might be writing low ASCII control characters to a file, but they can do so freely now.
ebiggz
approved these changes
Mar 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
Update the Write to File effect's newline mangling:
backlash nin the effect text with a literal newline.backslash backslash nin the text with abackslash n.sub, ASCII 1A (base 16) 26 (base 10), or htmlcharacter for temporary staging to skip over the newline regex.Applicable Issues
#3025
Testing
Thoroughly wrote several newlines and
backslash ncharacters to files, as desired.Only downside: no one will be able to intentionally write asub/ htmlcharacter to a file afterwards.edit: Verified intentionally writing
subcontrol characters.Screenshots