feat(effects): Default Effect Labels (#2127)#3040
Merged
ebiggz merged 21 commits intocrowbartools:v5from Mar 14, 2025
Merged
Conversation
…tting to disable functionality
CKY-
changed the title
ebiggz
reviewed
Mar 10, 2025
ebiggz
approved these changes
Mar 14, 2025
Member
ebiggz
left a comment
ebiggz
left a comment
There was a problem hiding this comment.
Looks good! Thanks for getting this old branch over the finish line
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
This PR adds default effect labels to a portion of Firebot's effects.
This feature is enabled by default, and can be disabled by the user by going to
Settings > Effects > Default Effect LabelsApplicable Issues
#2127
crowbartools/firebot-custom-scripts-types#38
Testing
Opened every updated effect and ensured default labels show up properly
Ensured default labels do not render when disabled in settings
Screenshots
Review
I have left a couple TODO comments where I need some help deciding on the best course of action. As such, this PR will be marked as a draft until I've received and addressed feedback
cvar property path
run command args
run program args
update role case/priority