fix(effects): Play Sound/Video File Handling (#2879)#3076
Merged
ebiggz merged 1 commit intocrowbartools:v5from Apr 2, 2025
Merged
fix(effects): Play Sound/Video File Handling (#2879)#3076ebiggz merged 1 commit intocrowbartools:v5from
ebiggz merged 1 commit intocrowbartools:v5from
Conversation
- Octothorpe ('#') and URL-encoded characters in local media file names
would break media previews and non-overlay playback.
- Switch to encoding those characters for the effect previews, and for
non-overlay output.
- Cull some ancient (5+ year) non-existent video placeholder frontend
logic.
ebiggz
approved these changes
Apr 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
Applicable Issues
#2879
Testing
Tested every conceivable variation of both effects with file names including octothorpe characters, as well as percent characters, and various URL-encoded symbols (e.g. %23, %25, %%%, %20, etc).
Screenshots
Before:
After:
Excerpted test cases (both for random from folder and per-file, each with output to default, device, or overlay):
