This repository was archived by the owner on Dec 3, 2025. It is now read-only.
Package upgrades: JS, Ruby, and Python Packages #1204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alaisgomes
previously approved these changes
Nov 5, 2024
…erformance and security
Hesbon5600
changed the title
…latest bug fixes and improvements
Hesbon5600
changed the title
….6.0 to leverage new features and bug fixes fix(demo.js): specify cookiecutter version in pipenv install command to ensure consistency across environments
…atest version for getting the latest features and bug fixes refactor(demo.js): change cookiecutter installation command to install any latest version feat(demo.js): change checkout branch from master to develop in cookiecutter commands to test latest changes in develop branch
…eaking changes in future versions refactor(demo.js): change branch from develop to master in cookiecutter commands for better stability and reliability
…behavior across environments refactor(demo.js): change django-scaffold checkout branch from master to PI-405-package-upgrade for testing new package upgrades
…age-upgrade to master to ensure usage of stable version
jbrendel
reviewed
Nov 7, 2024
| urllib3 = "==2.1.0" | ||
| django = "==3.2.23" | ||
| urllib3 = ">=2.2.2" | ||
| django = ">=4.2.16" |
There was a problem hiding this comment.
This is a big upgrade. But is it in line with other Django version upgrades elsewhere? I thought I saw an upgrade to a "4" version of Django elsewhere, too. Is that the same version?
Contributor
Author
There was a problem hiding this comment.
Yes. We have upgraded the Django version to 4.2.* in all other relevant reports. I made sure it works as expected.
jbrendel
approved these changes
Nov 7, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade the following packages:
Python
Ruby
JS
I have testes using the following commands:
Found some issues with django-scaffold which are resolved in this PR: crowdbotics/django-scaffold#832
Ticket
PI-405
Related tickets:
Related PRs:
Type of PR
Did you make changes to modules or created a new module?
Changes introduced
Describe the changes being introduced in this PR
Include screenshots if necessary
Please link any documentation reference that relate to the changes
Test and review
Describe how a reviewer should test your PR