Skip to content

Glossaries API updates#29

Merged
andrii-bodnar merged 2 commits into
crowdin:mainfrom
sabarish98:glossaries_api
Oct 26, 2022
Merged

Glossaries API updates#29
andrii-bodnar merged 2 commits into
crowdin:mainfrom
sabarish98:glossaries_api

Conversation

@sabarish98
Copy link
Copy Markdown
Contributor

Changes made in this PR:

  • Added support for Concept APIs
  • Added relevant spec cases
  • Changed rubocop offence rule for Metrics/ModuleLength to 256

Addresses issue #26

@sabarish98 sabarish98 mentioned this pull request Oct 26, 2022
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 26, 2022

Codecov Report

Merging #29 (7fa1d67) into main (66d485b) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #29      +/-   ##
==========================================
+ Coverage   97.84%   97.88%   +0.04%     
==========================================
  Files          57       57              
  Lines        2540     2586      +46     
==========================================
+ Hits         2485     2531      +46     
  Misses         55       55              
Impacted Files Coverage Δ
lib/crowdin-api/api_resources/glossaries.rb 98.91% <100.00%> (+0.29%) ⬆️
spec/api_resources/glossaries_spec.rb 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@andrii-bodnar
Copy link
Copy Markdown
Member

@sabarish98 looks good to me, thanks a lot for the contribution! 🎉

@andrii-bodnar andrii-bodnar linked an issue Oct 26, 2022 that may be closed by this pull request
@andrii-bodnar andrii-bodnar merged commit 76a5d55 into crowdin:main Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Glossaries API updates

2 participants