enhance: add remediation supported features bubble #624
Conversation
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
|
Good idea for the bubble! The only weird thing is the "Mode" bubble, which should not be a boolean (because it can live, stream or both). It leads to "Unsupported" mode for many remediation components. |
|
converting to draft till I have time to solve merge conflicts |
|
should we add a page for traefik ? it is appsec able |
enhance: add remediation component badges section in intro
rr404
force-pushed
the
remediation_support_features
branch
from
b762799 to
b8f0bd5
Compare
Can we assume that a bouncer with only one mode will have only Live ? so we just change the labels and not the logic of laurence's code (otherwise we'll have to passed something more than just a boolà) |
Most bouncers without a mode are stream typically. |
| <RemediationSupportBadge title='Metrics' description='Can send detailed metrics to LAPI' supported={Metrics} /> | ||
| <RemediationSupportBadge title='MTLS' description='Can do mutual TLS authentication to LAPI' supported={MTLS} /> | ||
| <RemediationSupportBadge title='Prometheus' description='Can expose metrics to Prometheus' supported={Prometheus} /> | ||
| <RemediationSupportBadge title='Mode' description='Can be configured in different modes, typically live or stream' support={modeSupport} /> |
There was a problem hiding this comment.
the description doesnt really match the present values anymore.
There was a problem hiding this comment.
true, I was just testing to see what looked like. but we need to do a slight improve on the Mode bubble
rr404
left a comment
rr404
left a comment
There was a problem hiding this comment.
LGTM for v0
We'll make updates immediatly for a few bouncers after this merge
3 participants
To help user see from a glance what feature the remediation supports