docker: always merge .yaml.local in conf_get()#2272
Conversation
With this change, all queries to the configuration will return the values from .local if they are set. However, conf_set will only write to .yaml and never to .local. This means users can potentially override values that are supposed to be under control of the entrypoint (credentials and things set from envvars).
|
@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.
DetailsI am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository. |
|
@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.
DetailsI am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository. |
Codecov Report
@@ Coverage Diff @@
## master #2272 +/- ##
==========================================
+ Coverage 51.24% 51.61% +0.36%
==========================================
Files 106 183 +77
Lines 14328 25532 +11204
==========================================
+ Hits 7343 13178 +5835
- Misses 6161 10825 +4664
- Partials 824 1529 +705
Flags with carried forward coverage won't be shown. Click here to find out more. see 118 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@LaurenceJJones can I have some feedback if this solves your use cases |
buixor
left a comment
buixor
left a comment
There was a problem hiding this comment.
code-wise ok, let's wait for @LaurenceJJones feedback :)
3 participants
With this change, all queries to the configuration will return the values from .local if they are set. However, conf_set will only write to .yaml and never to .local. This means users can potentially override values that are supposed to be under control of the entrypoint (credentials and things set from envvars).
See #2121