Skip to content

Comments

fix double push of metrics by properly handling tickers#2374

Merged
mmetc merged 2 commits intomasterfrom
metrics-interval
Jul 25, 2023
Merged

fix double push of metrics by properly handling tickers#2374
mmetc merged 2 commits intomasterfrom
metrics-interval

Conversation

@mmetc
Copy link
Contributor

@mmetc mmetc commented Jul 24, 2023

if the initial ticker interval is too small, metrics are sent twice every time crowdsec is reload or a machines is added

@github-actions
Copy link

@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@github-actions
Copy link

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@mmetc mmetc added the kind/fix label Jul 24, 2023
@mmetc mmetc added this to the 1.5.3 milestone Jul 24, 2023
@mmetc mmetc force-pushed the metrics-interval branch from 7d089f2 to 64f3ac4 Compare July 25, 2023 08:20
@mmetc mmetc changed the title fix double push of metrics by raising minimum interval fix double push of metrics by properly handling tickers Jul 25, 2023
@mmetc mmetc force-pushed the metrics-interval branch from 64f3ac4 to 4ca36c1 Compare July 25, 2023 09:30
@mmetc mmetc marked this pull request as ready for review July 25, 2023 09:30
@mmetc mmetc force-pushed the metrics-interval branch from 4ca36c1 to a17ab28 Compare July 25, 2023 09:30
@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Merging #2374 (7e66afd) into master (7106d39) will increase coverage by 0.14%.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##           master    #2374      +/-   ##
==========================================
+ Coverage   56.12%   56.26%   +0.14%     
==========================================
  Files         182      186       +4     
  Lines       25406    25792     +386     
==========================================
+ Hits        14259    14513     +254     
- Misses       9620     9712      +92     
- Partials     1527     1567      +40     
Flag Coverage Δ
bats 37.75% <80.00%> (+0.03%) ⬆️
unit-linux 54.82% <80.00%> (+0.16%) ⬆️
unit-windows 51.39% <80.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pkg/apiserver/apic_metrics.go 75.92% <80.00%> (+11.16%) ⬆️

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mmetc mmetc merged commit 395cace into master Jul 25, 2023
@mmetc mmetc deleted the metrics-interval branch July 25, 2023 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants