pkg/leakybucket: move LeakRoutine to method, rename parameters

[mmetc]

No description provided.

[github-actions]

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

• /area agent
• /area local-api
• /area cscli
• /area appsec
• /area security
• /area configuration

Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

[sabban]

lgtm

[codecov]

Codecov Report

❌ Patch coverage is 80.00000% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.13%. Comparing base (aac9e8c) to head (4f97002).
⚠️ Report is 1 commits behind head on master.

Files with missing lines	Patch %	Lines
pkg/leakybucket/bucket.go	79.76%	10 Missing and 7 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4243      +/-   ##
==========================================
+ Coverage   63.07%   63.13%   +0.05%     
==========================================
  Files         471      471              
  Lines       33433    33433              
==========================================
+ Hits        21089    21107      +18     
+ Misses      10225    10208      -17     
+ Partials     2119     2118       -1     

Flag	Coverage Δ
bats	46.56% <54.11%> (+0.04%)	⬆️
unit-linux	36.00% <75.29%> (+0.08%)	⬆️
unit-windows	24.38% <75.29%> (+0.03%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.