Skip to content

pkg/leakybucket: replace sycn.Map with map + mutex#4271

Merged
mmetc merged 2 commits intomasterfrom
leaky-store-mutex
Feb 2, 2026
Merged

pkg/leakybucket: replace sycn.Map with map + mutex#4271
mmetc merged 2 commits intomasterfrom
leaky-store-mutex

Conversation

@mmetc
Copy link
Contributor

@mmetc mmetc commented Feb 2, 2026

No description provided.

@mmetc mmetc added this to the 1.7.7 milestone Feb 2, 2026
@mmetc mmetc requested a review from sabban February 2, 2026 11:08
@github-actions
Copy link

github-actions bot commented Feb 2, 2026

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@codecov
Copy link

codecov bot commented Feb 2, 2026

Codecov Report

❌ Patch coverage is 88.88889% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.08%. Comparing base (8a2eb8d) to head (2f41943).
⚠️ Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
pkg/leakybucket/bucketstore.go 86.95% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #4271       +/-   ##
===========================================
+ Coverage   36.06%   63.08%   +27.01%     
===========================================
  Files         471      472        +1     
  Lines       33438    33449       +11     
===========================================
+ Hits        12060    21100     +9040     
+ Misses      20014    10227     -9787     
- Partials     1364     2122      +758     
Flag Coverage Δ
bats 46.60% <44.44%> (?)
unit-linux 35.96% <88.88%> (-0.03%) ⬇️
unit-windows 24.39% <88.88%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@sabban sabban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mmetc mmetc merged commit 1ad0b04 into master Feb 2, 2026
16 checks passed
@mmetc mmetc deleted the leaky-store-mutex branch February 2, 2026 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants