Skip to content

move calls to trace.ReportPanic() on top of goroutines#4338

Merged
mmetc merged 2 commits intomasterfrom
report-panic1
Feb 26, 2026
Merged

move calls to trace.ReportPanic() on top of goroutines#4338
mmetc merged 2 commits intomasterfrom
report-panic1

Conversation

@mmetc
Copy link
Contributor

@mmetc mmetc commented Feb 26, 2026

do not call ReportPanic() from plain functions, but where the goroutine is created

@mmetc mmetc added this to the 1.7.7 milestone Feb 26, 2026
@github-actions
Copy link

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@mmetc mmetc requested review from blotus and removed request for blotus February 26, 2026 15:18
@codecov
Copy link

codecov bot commented Feb 26, 2026

Codecov Report

❌ Patch coverage is 69.04762% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 62.95%. Comparing base (2a576ac) to head (69b7f73).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
pkg/apiserver/apiserver.go 57.89% 8 Missing ⚠️
cmd/crowdsec/run_in_svc_windows.go 0.00% 4 Missing ⚠️
pkg/acquisition/acquisition.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4338      +/-   ##
==========================================
- Coverage   62.99%   62.95%   -0.04%     
==========================================
  Files         473      473              
  Lines       33456    33465       +9     
==========================================
- Hits        21074    21067       -7     
- Misses      10270    10280      +10     
- Partials     2112     2118       +6     
Flag Coverage Δ
bats 46.52% <71.05%> (+<0.01%) ⬆️
unit-linux 35.83% <36.84%> (-0.11%) ⬇️
unit-windows 24.40% <36.84%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mmetc mmetc merged commit a32d269 into master Feb 26, 2026
16 checks passed
@mmetc mmetc deleted the report-panic1 branch February 26, 2026 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants