Fix IPv6 address parsing in envoy-logs parser#1659
Merged
LaurenceJJones merged 1 commit intocrowdsecurity:masterfrom Jan 27, 2026
Merged
Fix IPv6 address parsing in envoy-logs parser#1659LaurenceJJones merged 1 commit intocrowdsecurity:masterfrom
LaurenceJJones merged 1 commit intocrowdsecurity:masterfrom
Conversation
- Use lastIndexOf to extract IP from address:port format instead of split/join - Handle IPv6 addresses in brackets correctly for both JSON and CLF formats - Simplify expressions to match consistent style - Add test cases for IPv6 addresses in both JSON and CLF formats - Add test cases for multiple IPs in x-forwarded-for (upstream proxies) Fixes crowdsecurity#1658
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1658
Checklist