feat(*): Add Watcher client #22
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* AlertsClient
Collaborator
Author
|
Hi @gam6itko, I've created this new PR from your work. May I ask you to verify whether this implementation would meet your needs? I mainly refactored the code so that it only uses a new "Watcher" client. (I felt it was simpler and consistent with the existing "Bouncer" client) Thanks |
gam6itko
approved these changes
Dec 15, 2025
Contributor
|
@julienloizelet LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the continuation of #21
To simplify maintenance, it just uses a "Watcher" client (and not 2 separate clients "Watcher" and "Alerts").
This Watcher client aims to be able to handle "Operations about watchers" shown here: https://crowdsecurity.github.io/api_doc/index.html?urls.primaryName=LAPI#/watchers
This PR enables watcher some operations (alert push/search/delete/get). It refactors common logic into AbstractLapiClient and introduces comprehensive configuration/payload validation.