datastore/postgres: fix iterator exhaustion in alias insertion#89
Open
jvdm wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a bug in the
faster-alias-insertbranch whereinsertAliasesconsumes the single-passvulnIter(backed byjsonblob.RecordIter) before the main vulnerability insertion loop runs, resulting in zero vuln rows being inserted.The fix removes the separate
insertAliasespre-pass and instead collects alias namespaces and aliases during the mainvulnIterloop, then bulk-inserts them via a separate connection (outside the transaction) after the loop — preserving the deadlock-avoidance property.Also adds a test using a
sync.Once-guarded single-pass iterator that reproduces the bug.See test results on quay#1934.