Fixed Queue and Refactored Driver#88
Conversation
Multiple refactoring changes.
Implemented tests
There was a problem hiding this comment.
I've done some code style changes and such. This seems fine anyway.
One thing I have on mind though, that some providers like DigitalOcean allow to access the maximum droplet limit via its API, which could be used to give an answer for availability instead of simply falling always for true.
Plus that, a limit that could be set in an environment variable would be nice.
One thing I didn't comment you, is that I think though, as drivers are re-factored, I feel that we could just export the drivers by default, so we can simply count on the default import instead of doing specific ones. There should not be a need to do multiple exports anyway, as drivers should be kept separate from each one.
I agree with the point about exporting as default. We can go ahead and do that. For existing drivers I didn't want to actually finish implementing the isSpaceAvailable because it would have taken a bunch of research specific to each driver. We should open some issues to improve them but other than that it's fine to. |
jeda
left a comment
There was a problem hiding this comment.
It's all good to go then.
I'll open a new issue in order to actually look for availability plus more configuration for that. The base is already there, anyway.
Uh oh!
There was an error while loading. Please reload this page.